[asterisk-dev] [Code Review] 4296: PJSIP: Fix bugs and improve documentation of remote attended transfers

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4296/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 5:29 p.m.)


Review request for Asterisk Developers.


Changes
-------

Null-terminate the buffer that PJSIP writes the Replaces header into.


Bugs: ASTERISK-24376
    https://issues.asterisk.org/jira/browse/ASTERISK-24376


Repository: Asterisk


Description
-------

ASTERISK-24376 was created because at SIPit there was confusion about how to get remote attended transfers to work properly when using chan_pjsip.

To address this, I investigated the code and discerned what the intended way to perform a remote attended transfer is. I documented my findings on the following wiki page: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=31096903
Please review the wiki page to ensure it makes sense.

While setting up a remote attended transfer, I came across a couple of minor issues. The following bug fixes are attached on this review:
* When sending an INVITE with a Replaces header, the Replaces header was malformed. It had the word "Replaces" twice.
* There was an error message that made it sound like external_replaces was a context being searched for, when it's actually an extension. I changed the log message to be more clear.


Diffs (updated)
-----

  /branches/13/res/res_pjsip_refer.c 430178 

Diff: https://reviewboard.asterisk.org/r/4296/diff/


Testing
-------

I have manually tested this, and I've found that remote attended transfers work as expected with the patch applied. I'm in the process of writing a testsuite test but am fighting with PJSUA at the moment. Since I am going on vacation for a couple of weeks, I felt I should go ahead and get this review posted now. You'll see a testsuite review go up sometime at the start of 2015. Happy Holidays!


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150106/1843c042/attachment.html>