[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

Scott Griepentrog reviewboard at asterisk.org
Tue Jan 6 09:04:12 CST 2015



On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote:
> > Is this missing a sip.conf?

It's using the bridge test case which is built on sip and includes it's own default sip.conf.  Thus, I don't have to provide one in this test, and it would require changing the bridge test case, or at least creating a new test case - including support directories - so that one could easily switch a test to pjsip without much other changes.  Which is actually not a bad idea, but out of the scope of getting this test in.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4256/#review14078
-----------------------------------------------------------


On Dec. 31, 2014, 12:01 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4256/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24513
>     https://issues.asterisk.org/jira/browse/ASTERISK-24513
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test starts an attended transfer, converts to blonde mode by hanging up the transferer, and then fails the transfer by hanging up the transferee.  Then after allowing the recall attempt to complete, checks to insure that there are not leaked channels.
> 
> Improvements to channel_test_condition: count the actual channels listed in "core show channels" output to check for leaks.  Also added unittest.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/tests.yaml 6149 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/channel_test_condition.py 6149 
> 
> Diff: https://reviewboard.asterisk.org/r/4256/diff/
> 
> 
> Testing
> -------
> 
> Currently fails while ASTERISK-24513 is not yet patched.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150106/eb025ced/attachment.html>


More information about the asterisk-dev mailing list