[asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4303/
-----------------------------------------------------------

(Updated Jan. 2, 2015, 7:04 p.m.)


Review request for Asterisk Developers.


Changes
-------

Refactor and retest based on Kevin's comments.


Repository: Asterisk


Description
-------

Every time a registration started, sip_outbound_registration_response_cb bumps the ref count on client_state then pushes a handle_registration_response task.  handle_registration_response never unreffed it though.  So every time a registration goes out, the ref count goes up by one.

This patch adds the unreffs to handle_registration_response.


Diffs (updated)
-----

  branches/13/res/res_pjsip_outbound_registration.c 430163 

Diff: https://reviewboard.asterisk.org/r/4303/diff/


Testing
-------

Watched the ref count on client_state in no-auth registrations, auth-successful registrations and auth-failed registrations to make sure the ref count stayed stable.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150103/33e3dd2c/attachment.html>