[asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14558
-----------------------------------------------------------


<mjordan> file: for the proposed DNS API, are you envisioning having it act as a facade over a particular library? Or having a separate file/module register to the core?
<file> register
<file> the end result will be the same but it keeps the two boundaries more separate
<mjordan> the only problem I see with that is we'll have yet another loadable module that can't be unloaded
<file> we can either have it as a loadable module, or still an internal file that just registers with the core still
<mjordan> I kind of lack the latter
<mjordan> I doubt we'll be looking to hotswap DNS libraries
<file> I'm not so much looking at hot swapping - just swapping if something nicer comes along
<mjordan> true
<mjordan> You may want to think about adding a unit test enabled API only that allows us to add a test resolver
* oej has quit (Quit: Leaving.)
<mjordan> that way you can test out the threading mechanisms/callbacks from unit tests
* file nods

- Joshua Colp


On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4437/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 12:25 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A wiki page is present at:
> 
> https://wiki.asterisk.org/wiki/display/~jcolp/Asterisk+DNS+API
> 
> Which details a new DNS API for Asterisk. This exists as a thin wrapper over other resolver libraries. The core part provides a common interface and some additional features, such as NAPTR/SRV parsing and recurring lookups. Examples are provided which cover the common use cases for the API.
> 
> Some stuff to think about:
> 
> 1. Does this encompass everything we think a low level API should?
> 2. Are there any higher level APIs that would be useful to have?
> 3. Is the usage intuitive and easy?
> 4. Are there other examples which would help?
> 5. Do we want resolvers to be actual modules or keep them in-core?
> 6. Anything else you think of
> 
> Have at it!
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/4437/diff/
> 
> 
> Testing
> -------
> 
> I've logically run through the API and examples to ensure they provide what is needed for the future, to make them as easy as possible to use, and to ensure higher level APIs can be created.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150226/49e4c104/attachment-0001.html>