[asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

[Corey Farrell]

> On Feb. 17, 2015, 9:51 a.m., Joshua Colp wrote:
> > /branches/13/main/loader.c, line 1487
> > <https://reviewboard.asterisk.org/r/4428/diff/1/?file=71466#file71466line1487>
> >
> >     Why the !mod addition? Something trigger it?

codec_builtin.c runs __ast_codec_register with a NULL module.

Technically this is not required for 11, but I'd rather keep the function the same.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4428/#review14474
-----------------------------------------------------------


On Feb. 16, 2015, 1:58 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4428/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 1:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24796
>     https://issues.asterisk.org/jira/browse/ASTERISK-24796
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Allow modules that call ast_bucket_scheme_register or ast_codec_register to be unloaded during graceful shutdown only (13+ only).
> * Change __ast_module_shutdown_ref to be NULL safe (11+).
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/loader.c 431876 
>   /branches/13/main/codec.c 431876 
>   /branches/13/main/bucket.c 431876 
> 
> Diff: https://reviewboard.asterisk.org/r/4428/diff/
> 
> 
> Testing
> -------
> 
> Build, basic startup/shutdown test.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150217/cdda9e18/attachment.html>