[asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4427/#review14468
-----------------------------------------------------------



/branches/12/main/aoc.c
<https://reviewboard.asterisk.org/r/4427/#comment25002>

    I don't think this is the right way to fix the problem.
    
    This is really just working around the underlying problem: the AOC-E message in sig_pri is being raised too late in the process. Preferably, it should be raising the AOC-E event with the channel - currently, it is doing this after the channel has been destroyed.
    
    Right now, publishing to ast_channel_publish_blob without a channel will publish it to the all channel topic, which is not the right answer.
    
    If we can't hold onto the channel long enough, then we should at least:
    (a) Provide the channel name, and alter the AOC messages to look for that field
    (b) Alter the AOC AMI formatting to be tolerant of there not being a channel.
    
    
    



/branches/12/main/manager_channels.c
<https://reviewboard.asterisk.org/r/4427/#comment25001>

    We shouldn't be reaching this point with a NULL snapshot, if the producers aren't misbehaving.


- Matt Jordan


On Feb. 15, 2015, 4:33 p.m., roeften wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4427/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 4:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22670, ASTERISK-24689 and ASTERISK-24740
>     https://issues.asterisk.org/jira/browse/ASTERISK-22670
>     https://issues.asterisk.org/jira/browse/ASTERISK-24689
>     https://issues.asterisk.org/jira/browse/ASTERISK-24740
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Mostly checking for null and allowing a manager event to be generated without a channel specified (which seems to work).
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/manager_channels.c 431876 
>   /branches/12/main/aoc.c 431876 
> 
> Diff: https://reviewboard.asterisk.org/r/4427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> roeften
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150216/843b7ddc/attachment.html>