[asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4415/#review14453
-----------------------------------------------------------

Ship it!


I had comments on the PJSUA phone controller code, but I believe none of the findings would have any effect on how this test would be written. So, once the PJSUA phone controller is committed, I say commit away on this as well.

- Mark Michelson


On Feb. 12, 2015, 6:34 a.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4415/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 6:34 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Bugs: ASTERISK-24578, ASTERISK-24755 and ASTERISK-24782
>     https://issues.asterisk.org/jira/browse/ASTERISK-24578
>     https://issues.asterisk.org/jira/browse/ASTERISK-24755
>     https://issues.asterisk.org/jira/browse/ASTERISK-24782
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds the Attended Transfers from non-Stasis to a Stasis bridge tests 1.1 & 1.2 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826
> 
> Notes:
> * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/
> * The tests may occasionally fail due to bug ASTERISK-24755.
> * These tests constantly fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6379 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4415/diff/
> 
> 
> Testing
> -------
> 
> * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested.
> * Executed tests multiple times.
> * Reviewed logs to ensure the tests were executing as expected.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150212/fdcde847/attachment.html>