[asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4412/
-----------------------------------------------------------

(Updated Feb. 11, 2015, 10:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 431669


Bugs: ASTERISK-24701
    https://issues.asterisk.org/jira/browse/ASTERISK-24701


Repository: Asterisk


Description
-------

When writing to a websocket if a timeout occurred the underlying socket did not get closed/disconnected. This patch makes sure the websocket gets disconnected on a write timeout. Also a notice is logged stating that the websocket was disconnected.


Diffs
-----

  branches/13/res/res_http_websocket.c 431641 
  branches/13/res/ari/ari_websockets.c 431641 

Diff: https://reviewboard.asterisk.org/r/4412/diff/


Testing
-------

I had trouble getting an actual write timeout to occur, so I just forced an error on write to make sure the underlying socket would get closed and the notice was logged. Also ran relevant testsuite and unit tests.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150211/681d75f2/attachment.html>