[asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

Scott Griepentrog reviewboard at asterisk.org
Thu Feb 5 16:25:44 CST 2015

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.

Repository: Asterisk


A collection of small fixes to prevent Valgrind errors for your amusement and approval:

1) Config hooks: a) don't hold extra reference after creation of a hook, b) cleanup the container on shutdown

2) Util ast_join_delim: don't touch w[x] if x out of bounds of size

3) res_pjsip sync_task: prevent reference to sync task data struct if it gets freed after unlocked.


  /branches/13/res/res_pjsip.c 431571 
  /branches/13/main/utils.c 431571 
  /branches/13/main/config.c 431571 

Diff: https://reviewboard.asterisk.org/r/4407/diff/


In each case Valgrind did not show the same error again after the patch was added.


Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150205/c574bf10/attachment-0001.html>

More information about the asterisk-dev mailing list