[asterisk-dev] [Code Review] 4405: Fix ast_odbc_find_table function in res_odbc

[ibercom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4405/
-----------------------------------------------------------

(Updated Feb. 5, 2015, 3:35 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed wdoekes's comment.


Bugs: ASTERISK-24742
    https://issues.asterisk.org/jira/browse/ASTERISK-24742


Repository: Asterisk


Description
-------

This patch fixes an anomalous behavior in ast_odbc_find_table function with Asterisk Realtime.

- SELECT or INSERT operation generate a single command "SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED" in database engine before operation.
- UPDATE operation generates two commands "SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED" in database engine before operation.

The patch is trivial, just rearranges the call to ast_odbc_request_obj function. This isn't necessary when the table is cached.


Diffs (updated)
-----

  branches/11/res/res_odbc.c 431571 

Diff: https://reviewboard.asterisk.org/r/4405/diff/


Testing
-------

Log mysql usage.
It is working for a week without problems.


Thanks,

ibercom

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150205/2da3351c/attachment-0001.html>