[asterisk-dev] [Code Review] 4108: Weak References

Corey Farrell reviewboard at asterisk.org
Thu Feb 5 01:30:52 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
-----------------------------------------------------------

(Updated Feb. 5, 2015, 2:30 a.m.)


Review request for Asterisk Developers, George Joseph and rmudgett.


Changes
-------

Address Richard's findings.


Repository: Asterisk


Description
-------

This implements weak references.  The weak object is a real ao2 with normal reference counting of its own.  The original object is destroyed when the only reference remaining is from the weak object.


Diffs (updated)
-----

  /trunk/tests/test_astobj2_weaken.c PRE-CREATION 
  /trunk/main/astobj2.c 431571 
  /trunk/include/asterisk/astobj2.h 431571 

Diff: https://reviewboard.asterisk.org/r/4108/diff/


Testing
-------

Very little, I'm unsure how to actually test that this cannot race, since any potential for a race would be due to very exact timing.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150205/0c50baea/attachment-0001.html>


More information about the asterisk-dev mailing list