[asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4383/#review14405
-----------------------------------------------------------



branches/13/res/res_pjsip_config_wizard.c
<https://reviewboard.asterisk.org/r/4383/#comment24913>

    What if app is empty? What will happen?



branches/13/res/res_pjsip_config_wizard.c
<https://reviewboard.asterisk.org/r/4383/#comment24914>

    Won't this cause the hint to go away and then come back? What behavior does that cause for watchers (and by extension people subscribed to it using something like SIP)? This also opens up a window where someone may try to use the configured extension and it won't be available.


- Joshua Colp


On Jan. 30, 2015, 6:16 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4383/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 6:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Looking at the Super Awesome Company sample reminded me that creating hints is just plain gruntwork.  So you can now have the pjsip conifg wizard auto-create them for you.
> 
> Specifying 'hint_exten' in the wizard will create 'exten => <hint_exten>,hint/PJSIP/<wizard_id>' in whatever is specified for 'hint_context'.
> Specifying 'hint_application' in the wizard will create 'exten => <hint_exten>,1,<hint_application>' in whatever is specified for 'hint_context'.
> 
> The default for 'hint_context' is the endpoint's context.
> There's no default for 'hint_application'.  If not specified, no app is added.
> There's no default for 'hint_exten'.  If not specified, neither the hint itself nor the application will be created.
> 
> Some may think this is the slippery slope to users.conf but hints are a basic necessity for phones unlike voicemail, manager, etc that users.conf creates.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_config_wizard.c 431494 
>   branches/13/configs/samples/pjsip_wizard.conf.sample 431494 
> 
> Diff: https://reviewboard.asterisk.org/r/4383/diff/
> 
> 
> Testing
> -------
> 
> Existing config_wizard testsuite tests pass.
> Additional testsuite tests in the works.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150204/5ce1bbd4/attachment-0001.html>