[asterisk-dev] [Code Review] 4521: DTLS-crashes-ASTERISK-24832

[one47]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4521/#review15200
-----------------------------------------------------------


I have applied a cleaned-up version of this patch. I do not believe you need the 1-second wait loop at-all, but the rest of the patch looks clean, and after some research I even worked out why it helps :)

Yes, I think it should be progressed.

- one47


On March 25, 2015, 4:24 p.m., Stefan Engström wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4521/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 4:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Not in final form - What's essential to review is the extra check done before calling dtls_perform_handshake.
> 
> I'm aware that this patch is polluted with comments, bad spacing and ast_log-calls... I'll align the patch with https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines only if you judge the 'actual patch-contents' might be commitable
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_rtp_asterisk.c 433370 
> 
> Diff: https://reviewboard.asterisk.org/r/4521/diff/
> 
> 
> Testing
> -------
> 
> Yes, with this patch applied crashes has gone down to 0 in 30 days, and before patch it would crash once every 1-4 hours.
> 
> 
> Thanks,
> 
> Stefan Engström
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150428/10037db6/attachment.html>