[asterisk-dev] A Week with GIT/Gerrit

[Matthew Jordan]

On Fri, Apr 17, 2015 at 3:42 PM, Corey Farrell <git at cfware.com> wrote:
> My additions to the list:
> 1) Procedure for 'git review' of security related patches.  I think this
> could be done with an "asterisk-security" mirror repository setup in gerrit
> with restricted access.  I know this is already being thought about, just
> wanted to make sure it on the list.

I think there's a lot of things to think through with this, since
Gerrit - being a Git repo - tends to expose all patches in some form
or fashion. We could set up a completely separate server with
extremely limited access, but then we would need a separate review
server as well.

In the meantime, we might be able to use review board for this,
although it will mean porting it over to look at the Git repos.

It's certainly on the list to think through more.

> 2) Is there a command similar to 'git show-branch 13 master' that will
> operate on Change-Id's?  Something to show me the first line of all commits
> with change-id's that hit one branch but not the other.
> 3) It would be great if gerrit had the ability to detect the string
> "ASTERISK-#####" in commit messages and review comments, convert it to a
> JIRA link.

Apparently this is possible and is actually just a configuration issue:

http://gerrit.googlecode.com/svn/documentation/2.2.1/config-gerrit.html#_a_id_commentlink_a_section_commentlink

I'll try to get that set up this week.

> 4) 'git review -D' should not generate emails or allow the review to be seen
> on the web UI by anyone except the submitter.  I know this is probably a bug
> in gerrit, but still worth having on the list.

I will say that the last time there was a draft, it did show on the UI
as a Draft. I upgraded to 2.10.3.1 this weekend - maybe we'll get
lucky and it got fixed? :-)

> 5) We should add instructions for squashing commits before review somewhere
> on the Git or Gerrit usage page.
>

Ack. I'll try to get to that today. Maybe on the Git usage or Commit
message page, since it isn't explicitly tied to using Gerrit?

-- 
Matthew Jordan
Digium, Inc. | Director of Technology
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org