[asterisk-dev] Change in asterisk[13]: res_monitor: Add dependency on func_periodic_hook.

Joshua Colp (Code Review) asteriskteam at digium.com
Mon Apr 13 10:47:57 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: res_monitor: Add dependency on func_periodic_hook.
......................................................................


res_monitor: Add dependency on func_periodic_hook.

OPTIONAL_API has conditionals to define AST_OPTIONAL_API and
AST_OPTIONAL_API_ATTR differently based on if AST_API_MODULE is defined.
Unfortunately this is inside the include protection block, so only the
first status of AST_API_MODULE is respected.  For example res_monitor
is an optional API provider, but uses func_periodic_hook.  This makes
func_periodic_hook non-optional to res_monitor.

ASTERISK-17608 #close
Reported by: Warren Selby

Change-Id: I8fcf2a5e7b481893e17484ecde4f172c9ffb5679
---
M res/res_monitor.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/res/res_monitor.c b/res/res_monitor.c
index 872f565..ebf9843 100644
--- a/res/res_monitor.c
+++ b/res/res_monitor.c
@@ -24,6 +24,7 @@
  */
 
 /*** MODULEINFO
+	<depend type="module">func_periodic_hook</depend>
 	<support_level>core</support_level>
  ***/
  

-- 
To view, visit https://gerrit.asterisk.org/72
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fcf2a5e7b481893e17484ecde4f172c9ffb5679
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-dev mailing list