[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

[George Joseph (Code Review)]

Hello Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/58

to look at the new patch set (#4).

Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
......................................................................

git migration: Refactor the ASTERISK_FILE_VERSION macro

Git does not support the ability to replace a token with a version
string during check-in. While it does have support for replacing a
token on clone, this is somewhat sub-optimal: the token is replaced
with the object hash, which is not particularly easy for human
consumption. What's more, in practice, the source file version was often
not terribly useful. Generally, when triaging bugs, the overall version
of Asterisk is far more useful than an individual SVN version of a file. As a
result, this patch removes Asterisk's support for showing source file
versions.

Specifically, it does the following:

* Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
  remove passing the version in with the macro. Other facilities
  than 'core show file version' make use of the file names, such as
  setting a debug level only on a specific file. As such, the act of
  registering source files with the Asterisk core still has use. The
  macro rename now reflects the new macro purpose.

* main/asterisk:
  - Refactor the file_version structure to reflect that it no longer
    tracks a version field.
  - Remove the "core show file version" CLI command. Without the file
    version, it is no longer useful.
  - Remove the ast_file_version_find function. The file version is no
    longer tracked.
  - Rename ast_register_file_version/ast_unregister_file_version to
    ast_register_file/ast_unregister_file, respectively.

* main/manager: Remove value from the Version key of the ModuleCheck
  Action. The actual key itself has not been removed, as doing so would
  absolutely constitute a backwards incompatible change. However, since
  the file version is no longer tracked, there is no need to attempt to
  include it in the Version key.

* UPGRADE: Add notes for:
  - Modification to the ModuleCheck AMI Action
  - Removal of the "core show file version" CLI command

Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
---
M UPGRADE.txt
M addons/cdr_mysql.c
M addons/chan_mobile.c
M addons/format_mp3.c
M addons/ooh323c/src/ooSocket.c
M addons/res_config_mysql.c
M apps/app_adsiprog.c
M apps/app_agent_pool.c
M apps/app_alarmreceiver.c
M apps/app_amd.c
M apps/app_authenticate.c
M apps/app_bridgewait.c
M apps/app_cdr.c
M apps/app_celgenuserevent.c
M apps/app_chanisavail.c
M apps/app_channelredirect.c
M apps/app_chanspy.c
M apps/app_confbridge.c
M apps/app_controlplayback.c
M apps/app_dahdiras.c
M apps/app_db.c
M apps/app_dial.c
M apps/app_dictate.c
M apps/app_directed_pickup.c
M apps/app_directory.c
M apps/app_disa.c
M apps/app_dumpchan.c
M apps/app_echo.c
M apps/app_exec.c
M apps/app_externalivr.c
M apps/app_fax.c
M apps/app_festival.c
M apps/app_flash.c
M apps/app_followme.c
M apps/app_forkcdr.c
M apps/app_getcpeid.c
M apps/app_ices.c
M apps/app_image.c
M apps/app_ivrdemo.c
M apps/app_jack.c
M apps/app_macro.c
M apps/app_meetme.c
M apps/app_milliwatt.c
M apps/app_minivm.c
M apps/app_mixmonitor.c
M apps/app_morsecode.c
M apps/app_mp3.c
M apps/app_nbscat.c
M apps/app_originate.c
M apps/app_osplookup.c
M apps/app_page.c
M apps/app_playback.c
M apps/app_playtones.c
M apps/app_privacy.c
M apps/app_queue.c
M apps/app_read.c
M apps/app_readexten.c
M apps/app_record.c
M apps/app_saycounted.c
M apps/app_sayunixtime.c
M apps/app_senddtmf.c
M apps/app_sendtext.c
M apps/app_setcallerid.c
M apps/app_skel.c
M apps/app_sms.c
M apps/app_softhangup.c
M apps/app_speech_utils.c
M apps/app_stack.c
M apps/app_stasis.c
M apps/app_system.c
M apps/app_talkdetect.c
M apps/app_test.c
M apps/app_transfer.c
M apps/app_url.c
M apps/app_userevent.c
M apps/app_verbose.c
M apps/app_voicemail.c
M apps/app_waitforring.c
M apps/app_waitforsilence.c
M apps/app_waituntil.c
M apps/app_while.c
M apps/app_zapateller.c
M apps/confbridge/conf_chan_announce.c
M apps/confbridge/conf_chan_record.c
M apps/confbridge/conf_config_parser.c
M apps/confbridge/confbridge_manager.c
M bridges/bridge_builtin_features.c
M bridges/bridge_builtin_interval_features.c
M bridges/bridge_holding.c
M bridges/bridge_native_rtp.c
M bridges/bridge_simple.c
M bridges/bridge_softmix.c
M cdr/cdr_adaptive_odbc.c
M cdr/cdr_csv.c
M cdr/cdr_custom.c
M cdr/cdr_manager.c
M cdr/cdr_odbc.c
M cdr/cdr_pgsql.c
M cdr/cdr_radius.c
M cdr/cdr_sqlite.c
M cdr/cdr_sqlite3_custom.c
M cdr/cdr_syslog.c
M cdr/cdr_tds.c
M cel/cel_custom.c
M cel/cel_manager.c
M cel/cel_odbc.c
M cel/cel_pgsql.c
M cel/cel_radius.c
M cel/cel_sqlite3_custom.c
M cel/cel_tds.c
M channels/chan_alsa.c
M channels/chan_bridge_media.c
M channels/chan_console.c
M channels/chan_dahdi.c
M channels/chan_iax2.c
M channels/chan_mgcp.c
M channels/chan_misdn.c
M channels/chan_motif.c
M channels/chan_nbs.c
M channels/chan_oss.c
M channels/chan_phone.c
M channels/chan_pjsip.c
M channels/chan_rtp.c
M channels/chan_sip.c
M channels/chan_skinny.c
M channels/chan_unistim.c
M channels/console_board.c
M channels/console_video.c
M channels/dahdi/bridge_native_dahdi.c
M channels/iax2/codec_pref.c
M channels/iax2/firmware.c
M channels/iax2/format_compatibility.c
M channels/iax2/parser.c
M channels/iax2/provision.c
M channels/misdn_config.c
M channels/pjsip/dialplan_functions.c
M channels/sip/config_parser.c
M channels/sip/dialplan_functions.c
M channels/sip/reqresp_parser.c
M channels/sip/route.c
M channels/sip/security_events.c
M channels/vgrabbers.c
M codecs/codec_a_mu.c
M codecs/codec_adpcm.c
M codecs/codec_alaw.c
M codecs/codec_dahdi.c
M codecs/codec_g722.c
M codecs/codec_g726.c
M codecs/codec_gsm.c
M codecs/codec_ilbc.c
M codecs/codec_lpc10.c
M codecs/codec_resample.c
M codecs/codec_speex.c
M codecs/codec_ulaw.c
M formats/format_g719.c
M formats/format_g723.c
M formats/format_g726.c
M formats/format_g729.c
M formats/format_gsm.c
M formats/format_h263.c
M formats/format_h264.c
M formats/format_ilbc.c
M formats/format_jpeg.c
M formats/format_ogg_vorbis.c
M formats/format_pcm.c
M formats/format_siren14.c
M formats/format_siren7.c
M formats/format_sln.c
M formats/format_vox.c
M formats/format_wav.c
M formats/format_wav_gsm.c
M funcs/func_aes.c
M funcs/func_base64.c
M funcs/func_blacklist.c
M funcs/func_callcompletion.c
M funcs/func_callerid.c
M funcs/func_cdr.c
M funcs/func_channel.c
M funcs/func_config.c
M funcs/func_curl.c
M funcs/func_cut.c
M funcs/func_db.c
M funcs/func_devstate.c
M funcs/func_dialgroup.c
M funcs/func_dialplan.c
M funcs/func_enum.c
M funcs/func_env.c
M funcs/func_extstate.c
M funcs/func_frame_trace.c
M funcs/func_global.c
M funcs/func_groupcount.c
M funcs/func_hangupcause.c
M funcs/func_iconv.c
M funcs/func_jitterbuffer.c
M funcs/func_lock.c
M funcs/func_logic.c
M funcs/func_math.c
M funcs/func_md5.c
M funcs/func_module.c
M funcs/func_odbc.c
M funcs/func_periodic_hook.c
M funcs/func_pitchshift.c
M funcs/func_pjsip_aor.c
M funcs/func_pjsip_contact.c
M funcs/func_pjsip_endpoint.c
M funcs/func_presencestate.c
M funcs/func_rand.c
M funcs/func_realtime.c
M funcs/func_sha1.c
M funcs/func_shell.c
M funcs/func_sorcery.c
M funcs/func_speex.c
M funcs/func_sprintf.c
M funcs/func_srv.c
M funcs/func_strings.c
M funcs/func_sysinfo.c
M funcs/func_talkdetect.c
M funcs/func_timeout.c
M funcs/func_uri.c
M funcs/func_version.c
M funcs/func_vmcount.c
M funcs/func_volume.c
M include/asterisk.h
M main/abstract_jb.c
M main/acl.c
M main/alaw.c
M main/aoc.c
M main/app.c
M main/ast_expr2.c
M main/ast_expr2f.c
M main/asterisk.c
M main/astfd.c
M main/astmm.c
M main/astobj2.c
M main/astobj2_container.c
M main/astobj2_hash.c
M main/astobj2_rbtree.c
M main/audiohook.c
M main/autochan.c
M main/autoservice.c
M main/backtrace.c
M main/bridge.c
M main/bridge_after.c
M main/bridge_basic.c
M main/bridge_channel.c
M main/bridge_roles.c
M main/bucket.c
M main/callerid.c
M main/ccss.c
M main/cdr.c
M main/cel.c
M main/channel.c
M main/channel_internal_api.c
M main/chanvars.c
M main/cli.c
M main/codec.c
M main/codec_builtin.c
M main/config.c
M main/config_options.c
M main/core_local.c
M main/core_unreal.c
M main/crypt.c
M main/data.c
M main/datastore.c
M main/db.c
M main/devicestate.c
M main/dial.c
M main/dns.c
M main/dns_core.c
M main/dns_naptr.c
M main/dns_query_set.c
M main/dns_recurring.c
M main/dns_srv.c
M main/dns_tlsa.c
M main/dnsmgr.c
M main/dsp.c
M main/endpoints.c
M main/enum.c
M main/event.c
M main/features.c
M main/file.c
M main/fixedjitterbuf.c
M main/format.c
M main/format_cache.c
M main/format_cap.c
M main/format_compatibility.c
M main/frame.c
M main/framehook.c
M main/fskmodem_float.c
M main/fskmodem_int.c
M main/global_datastores.c
M main/hashtab.c
M main/heap.c
M main/http.c
M main/image.c
M main/indications.c
M main/io.c
M main/jitterbuf.c
M main/json.c
M main/libasteriskssl.c
M main/loader.c
M main/lock.c
M main/logger.c
M main/manager.c
M main/manager_bridges.c
M main/manager_channels.c
M main/manager_endpoints.c
M main/manager_mwi.c
M main/manager_system.c
M main/md5.c
M main/message.c
M main/mixmonitor.c
M main/named_acl.c
M main/netsock.c
M main/netsock2.c
M main/optional_api.c
M main/parking.c
M main/pbx.c
M main/pickup.c
M main/plc.c
M main/presencestate.c
M main/privacy.c
M main/rtp_engine.c
M main/say.c
M main/sched.c
M main/sdp_srtp.c
M main/security_events.c
M main/sem.c
M main/slinfactory.c
M main/smoother.c
M main/sorcery.c
M main/srv.c
M main/stasis.c
M main/stasis_bridges.c
M main/stasis_cache.c
M main/stasis_cache_pattern.c
M main/stasis_channels.c
M main/stasis_endpoints.c
M main/stasis_message.c
M main/stasis_message_router.c
M main/stasis_system.c
M main/stdtime/localtime.c
M main/strings.c
M main/stun.c
M main/syslog.c
M main/taskprocessor.c
M main/tcptls.c
M main/tdd.c
M main/term.c
M main/test.c
M main/threadstorage.c
M main/timing.c
M main/translate.c
M main/udptl.c
M main/ulaw.c
M main/utils.c
M main/xml.c
M main/xmldoc.c
M pbx/dundi-parser.c
M pbx/pbx_ael.c
M pbx/pbx_config.c
M pbx/pbx_dundi.c
M pbx/pbx_loopback.c
M pbx/pbx_lua.c
M pbx/pbx_realtime.c
M pbx/pbx_spool.c
M res/ael/ael.tab.c
M res/ael/ael_lex.c
M res/ael/pval.c
M res/ari/ari_model_validators.c
M res/ari/ari_websockets.c
M res/ari/cli.c
M res/ari/config.c
M res/ari/resource_applications.c
M res/ari/resource_asterisk.c
M res/ari/resource_bridges.c
M res/ari/resource_channels.c
M res/ari/resource_device_states.c
M res/ari/resource_endpoints.c
M res/ari/resource_events.c
M res/ari/resource_mailboxes.c
M res/ari/resource_playbacks.c
M res/ari/resource_recordings.c
M res/ari/resource_sounds.c
M res/parking/parking_applications.c
M res/parking/parking_bridge_features.c
M res/parking/parking_manager.c
M res/parking/parking_tests.c
M res/parking/parking_ui.c
M res/res_adsi.c
M res/res_ael_share.c
M res/res_agi.c
M res/res_ari.c
M res/res_ari_applications.c
M res/res_ari_asterisk.c
M res/res_ari_bridges.c
M res/res_ari_channels.c
M res/res_ari_device_states.c
M res/res_ari_endpoints.c
M res/res_ari_events.c
M res/res_ari_mailboxes.c
M res/res_ari_model.c
M res/res_ari_playbacks.c
M res/res_ari_recordings.c
M res/res_ari_sounds.c
M res/res_calendar.c
M res/res_calendar_caldav.c
M res/res_calendar_ews.c
M res/res_calendar_exchange.c
M res/res_calendar_icalendar.c
M res/res_chan_stats.c
M res/res_clialiases.c
M res/res_clioriginate.c
M res/res_config_curl.c
M res/res_config_ldap.c
M res/res_config_odbc.c
M res/res_config_pgsql.c
M res/res_config_sqlite.c
M res/res_config_sqlite3.c
M res/res_convert.c
M res/res_corosync.c
M res/res_crypto.c
M res/res_curl.c
M res/res_fax.c
M res/res_fax_spandsp.c
M res/res_format_attr_celt.c
M res/res_format_attr_h263.c
M res/res_format_attr_h264.c
M res/res_format_attr_opus.c
M res/res_format_attr_silk.c
M res/res_hep.c
M res/res_hep_pjsip.c
M res/res_hep_rtcp.c
M res/res_http_post.c
M res/res_http_websocket.c
M res/res_limit.c
M res/res_monitor.c
M res/res_musiconhold.c
M res/res_mutestream.c
M res/res_mwi_external.c
M res/res_mwi_external_ami.c
M res/res_odbc.c
M res/res_parking.c
M res/res_phoneprov.c
M res/res_pjsip/security_events.c
M res/res_pjsip_config_wizard.c
M res/res_pjsip_dlg_options.c
M res/res_pjsip_log_forwarder.c
M res/res_pjsip_logger.c
M res/res_pjsip_sdp_rtp.c
M res/res_pjsip_t38.c
M res/res_pktccops.c
M res/res_realtime.c
M res/res_resolver_unbound.c
M res/res_rtp_asterisk.c
M res/res_rtp_multicast.c
M res/res_security_log.c
M res/res_smdi.c
M res/res_snmp.c
M res/res_sorcery_astdb.c
M res/res_sorcery_config.c
M res/res_sorcery_memory.c
M res/res_sorcery_realtime.c
M res/res_speech.c
M res/res_srtp.c
M res/res_stasis.c
M res/res_stasis_answer.c
M res/res_stasis_device_state.c
M res/res_stasis_mailbox.c
M res/res_stasis_playback.c
M res/res_stasis_recording.c
M res/res_stasis_snoop.c
M res/res_stasis_test.c
M res/res_statsd.c
M res/res_stun_monitor.c
M res/res_timing_dahdi.c
M res/res_timing_pthread.c
M res/res_xmpp.c
M res/snmp/agent.c
M res/stasis/app.c
M res/stasis/command.c
M res/stasis/control.c
M res/stasis/messaging.c
M res/stasis/stasis_bridge.c
M res/stasis_recording/stored.c
M tests/test_abstract_jb.c
M tests/test_acl.c
M tests/test_amihooks.c
M tests/test_aoc.c
M tests/test_app.c
M tests/test_ari.c
M tests/test_ari_model.c
M tests/test_ast_format_str_reduce.c
M tests/test_astobj2.c
M tests/test_astobj2_thrash.c
M tests/test_bucket.c
M tests/test_callerid.c
M tests/test_cdr.c
M tests/test_cel.c
M tests/test_channel_feature_hooks.c
M tests/test_config.c
M tests/test_core_codec.c
M tests/test_core_format.c
M tests/test_db.c
M tests/test_devicestate.c
M tests/test_dlinklists.c
M tests/test_endpoints.c
M tests/test_event.c
M tests/test_expr.c
M tests/test_format_cache.c
M tests/test_format_cap.c
M tests/test_func_file.c
M tests/test_gosub.c
M tests/test_hashtab_thrash.c
M tests/test_heap.c
M tests/test_jitterbuf.c
M tests/test_json.c
M tests/test_linkedlists.c
M tests/test_locale.c
M tests/test_logger.c
M tests/test_message.c
M tests/test_netsock2.c
M tests/test_optional_api.c
M tests/test_pbx.c
M tests/test_poll.c
M tests/test_res_stasis.c
M tests/test_sched.c
M tests/test_security_events.c
M tests/test_skel.c
M tests/test_sorcery.c
M tests/test_sorcery_astdb.c
M tests/test_sorcery_realtime.c
M tests/test_stasis.c
M tests/test_stasis_channels.c
M tests/test_stasis_endpoints.c
M tests/test_strings.c
M tests/test_substitution.c
M tests/test_time.c
M tests/test_uri.c
M tests/test_utils.c
M tests/test_voicemail_api.c
M tests/test_websocket_client.c
M tests/test_xml_escape.c
M utils/ael_main.c
M utils/astdb2sqlite3.c
M utils/astman.c
M utils/check_expr.c
M utils/conf2ael.c
548 files changed, 618 insertions(+), 730 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/58/58/4
-- 
To view, visit https://gerrit.asterisk.org/58
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>