[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: git migration: Remove support for file versions
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:

Line 390: 	return NULL;
> That's a very good idea.
Agreed on the CLI command.

The AMI action is to check if a module is loaded, so even without the file version functionality it is still useful.  Additionally I'm thinking that in trunk we could add a version string to the module info structure, so the module check response would provide a useful version again.  Built-in modules would just use the version of Asterisk they were built against, 3rd party modules would have the option to provide their own version string.

So for the AMI action in 11/13 we should note in UPGRADE that the Version field is no longer useful.


-- 
To view, visit https://gerrit.asterisk.org/61
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes