[asterisk-dev] How to get peer review for patch to deprecated module

Matthew Jordan mjordan at digium.com
Sun Apr 12 18:10:14 CDT 2015


On Sun, Apr 12, 2015 at 11:26 AM, Alex Villací­s Lasso
<a_villacis at palosanto.com> wrote:
> El 11/04/15 a las 22:59, Matthew Jordan escribió:
>>
>> On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso
>> <a_villacis at palosanto.com> wrote:

<snip>

>> I'd recommend doing the following:
>>
>> * Re-open ASTERISK-20347 and attach the patch to the issue after
>> signing a CLA [1]. Regardless of the state of the source control for
>> Asterisk, your patch will at least be tracked in the project. Again,
>> I'll be happy to re-open the issue once you've confirmed you're
>> willing to sign a CLA and/or have already done so.
>
> I have already signed a license agreement for user a_villacis on JIRA. I
> have also uploaded the patch (against 11.17.0) on ASTERISK-20347. How do I
> proceed to get the bug reopened?

I've re-opened the bug. Thanks for attaching the patch.

I'd highly recommend posting the patch for review on Gerrit. While
things are a bit in a state of flux - in fact, we're fleshing out some
policy ideas right now - you should be able to post the patch for
review against the Asterisk 11 branch at a minimum.

To do that, please follow the instructions on the wiki:

https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

Note that since you are posting this against the 11 branch, you'll
want to invoke git review with that branch:

git review -t ASTERISK-20347 11

-- 
Matthew Jordan
Digium, Inc. | Director of Technology
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org



More information about the asterisk-dev mailing list