[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
......................................................................


Patch Set 1:

(2 comments)

Couple minor things then this is good to go.

https://gerrit.asterisk.org/#/c/42/1/.gitignore
File .gitignore:

Line 6: # *~
I suspect we do want to ignore *~


Line 10: **.so
Please add *.eo for embedded objects.  Also *.ii, *.oo for C++ modules.

Honestly I'm not sure the purpose of the two stars in **.so or others like this.  Why not just use *.so?  That would apply to all dirs.


-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes