[asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

[Matt Jordan]

> On April 10, 2015, 9:50 a.m., Matt Jordan wrote:
> > I'm going to go ahead and post this for review on Gerrit (gerrit.asterisk.org) - particularly since the 'findings' were very minor.
> > 
> > That will allow us to go ahead and commit the patch for the auto-dtmf mode ahead of the move to Git next week.

Actually, I just noticed that the pcap files containing the RFC 4733 DTMF and the Inband DTMF were never attached to the review. Can you svn add them and post them up here? Barring that, attaching them to the Asterisk issue would suffice.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4576/#review15179
-----------------------------------------------------------


On April 2, 2015, 9:04 a.m., yaron nahum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4576/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 9:04 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24706
>     https://issues.asterisk.org/jira/browse/ASTERISK-24706
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is the testsuite test to test the auto_dtmf option added by review:
> https://reviewboard.asterisk.org/r/4438/
> 
> The test passes.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 6564 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/sipp/dtmf_rfc2833.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/sipp/dtmf_inband.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> yaron nahum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150410/d0e056de/attachment.html>