[asterisk-dev] [Code Review] 4587: pjsip_options: Add qualify_timeout processing and eventing

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4587/
-----------------------------------------------------------

(Updated April 10, 2015, 12:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Josh's comments.
Killed a few more RAII_VARs.
Added CHANGES.
Added the alembic script which I forgot to 'svn add' before creating the patch.


Bugs: ASTERISK-24863
    https://issues.asterisk.org/jira/browse/ASTERISK-24863


Repository: Asterisk


Description
-------

This is the second follow-on to https://reviewboard.asterisk.org/r/4572/ and the discussion at http://lists.digium.com/pipermail/asterisk-dev/2015-March/073921.html 

The basic issues are that changes in contact status don't cause events to be emitted for the associated endpoint.  Only dynamic contact add/delete actions update the endpoint.  Also, the qualify timeout is fixed by pjsip at 32 seconds which is a long time.

This patch makes use of the new transaction timeout feature in r4585 and provides the following capabilities...

1.  A new aor/contact variable 'qualify_timeout' has been added that allows the user to specify the maximum time in milliseconds to wait for a response to an OPTIONS mesasge.  The default is 3000ms.  When the timer expires, the contact is marked unavailable.

2.  Contact status changes are now propagated up to the endpoint as follows...  When any contact is 'Available', the endpoint is marked as 'Reachable'.  When all contacts are 'Unavailable', the endpoint is marked as 'Unreachable'.  The existing endpoint events are generated appropriately.


Diffs (updated)
-----

  branches/13/res/res_pjsip/pjsip_options.c 434638 
  branches/13/res/res_pjsip/pjsip_configuration.c 434638 
  branches/13/res/res_pjsip/location.c 434638 
  branches/13/res/res_pjsip.c 434638 
  branches/13/main/endpoints.c 434638 
  branches/13/include/asterisk/res_pjsip.h 434638 
  branches/13/include/asterisk/endpoints.h 434638 
  branches/13/contrib/ast-db-manage/config/versions/2256a84ca226_add_pjsip_qualify_timeout.py PRE-CREATION 
  branches/13/configs/samples/pjsip.conf.sample 434638 
  branches/13/CHANGES 434638 

Diff: https://reviewboard.asterisk.org/r/4587/diff/


Testing
-------

Existing tests are unchanged.  I'm working on new testsuite tests to check the new functionality.

Tested-by: Dmitriy Serov


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150410/293f109c/attachment.html>