[asterisk-dev] Change in testsuite[master]: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Matt Jordan (Code Review) asteriskteam at digium.com
Fri Apr 10 11:30:11 CDT 2015


Matt Jordan has submitted this change and it was merged.

Change subject: res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.
......................................................................


res_phoneprov_pjsip: Disconnect HTTP before stopping Asterisk.

Leaving an HTTP connection open causes Asterisk to report a reference
leak.  This change ensures the connection is closed before stopping
Asterisk.

Change-Id: I5553af9cbfdc1d68110036eaadcfe5db3570928f
---
M tests/phoneprov/res_phoneprov_pjsip/run-test
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, approved; Verified
  Jared K. Smith: Looks good to me, but someone else must approve



diff --git a/tests/phoneprov/res_phoneprov_pjsip/run-test b/tests/phoneprov/res_phoneprov_pjsip/run-test
index 9288929..3a2b9fa 100755
--- a/tests/phoneprov/res_phoneprov_pjsip/run-test
+++ b/tests/phoneprov/res_phoneprov_pjsip/run-test
@@ -65,6 +65,12 @@
 
         self.stop_reactor()
 
+    def stop_reactor(self):
+        if self.con:
+            self.con.close()
+        super(ResPhoneprovTest, self).stop_reactor()
+
+
 def main():
     test = ResPhoneprovTest()
     reactor.run()

-- 
To view, visit https://gerrit.asterisk.org/35
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5553af9cbfdc1d68110036eaadcfe5db3570928f
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jared K. Smith <jaredsmith at jaredsmith.net>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-dev mailing list