[asterisk-dev] Change in testsuite[master]: pjsip/dtmf_incompatible: Wait 1 second before hanging up Alice

[Matt Jordan (Code Review)]

Matt Jordan has submitted this change and it was merged.

Change subject: pjsip/dtmf_incompatible: Wait 1 second before hanging up Alice
......................................................................


pjsip/dtmf_incompatible: Wait 1 second before hanging up Alice

The dtmf_incompatible test bounced on one of the CI build agents due to
only receiving a single BridgeLeave event. This was because Alice never
made it into the bridge: the BYE request was received from the SIPp
scenario prior to her channel fully entering the bridge.

This patch simply puts an additional <pause> into the SIPp scenario that
waits for one second before sending the BYE request. While waits and
pauses are generally not ideal, it is reasonable to expect that a
channel will make it into a bridge after one second. If not, we probably
have larger concerns.

Change-Id: Ia2a5f42255019f7fef2aa3d6cba1bce5123329d8
---
M tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, approved; Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml b/tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml
index 9f031db..e44cc94 100644
--- a/tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml
+++ b/tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml
@@ -56,6 +56,8 @@
 
   <recv request="ACK" rtd="true" crlf="true" />
 
+  <pause milliseconds="1000" />
+
   <send retrans="500">
     <![CDATA[
 

-- 
To view, visit https://gerrit.asterisk.org/38
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2a5f42255019f7fef2aa3d6cba1bce5123329d8
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>