[asterisk-dev] [Code Review] 4607: bridge_softmix.c, channel.c: Minor code simplification and cleanup.

Joshua Colp reviewboard at asterisk.org
Thu Apr 9 14:54:14 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4607/#review15165
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On April 9, 2015, 5:04 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4607/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 5:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Made code easier to follow in bridge_softmix.c:analyse_softmix_stats()
> and made some debug messages more helpful.
> 
> * Made some debug and warning messages more helpful in
> channel.c:set_format().
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/channel.c 434509 
>   /branches/13/bridges/bridge_softmix.c 434509 
> 
> Diff: https://reviewboard.asterisk.org/r/4607/diff/
> 
> 
> Testing
> -------
> 
> Items found while researching code for ASTERISK-24841.  It compiles.  Warm fuzzy because it was part of code put in while testing overall code for ASTERISK-24841.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150409/0799f16b/attachment.html>


More information about the asterisk-dev mailing list