[asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4606/#review15160
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On April 9, 2015, 5:05 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4606/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 5:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24835
>     https://issues.asterisk.org/jira/browse/ASTERISK-24835
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> After the "progressinband" value setting of "never" was updated to never send a 183 this separated its use from the "no" value. Since "never" was the default, but most users probably expect "no" this patch updates the default for the "progressinband" setting to "no".
> 
> 
> Diffs
> -----
> 
>   branches/13/configs/samples/sip.conf.sample 434508 
>   branches/13/channels/sip/include/sip.h 434508 
>   branches/13/channels/chan_sip.c 434508 
>   branches/13/CHANGES 434508 
> 
> Diff: https://reviewboard.asterisk.org/r/4606/diff/
> 
> 
> Testing
> -------
> 
> Started Asterisk and loaded chan_sip with the new default value for progressinband. Check to make sure that is what it was set to. Changed the setting to the other values and reloaded/checked between each to make sure those got set correctly as well.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150409/abfa33ad/attachment.html>