[asterisk-dev] Change in testsuite[master]: Testsuite: Caller & callee initiated local attended transfer...

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: Testsuite: Caller & callee initiated local attended transfers to application.
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.asterisk.org/#/c/34/1//COMMIT_MSG
Commit Message:

Line 11: 
Please add the ASTERISK issue to the commit message.


https://gerrit.asterisk.org/#/c/34/1/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_app/configs/ast1/pjsip.conf
File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_app/configs/ast1/pjsip.conf:

Line 25: ; TODO remove
       : ;contact=sip:alice at 127.0.0.1:5061\;transport=udp
I'd just remove it at this point :-)


Line 40: ; TODO remove
       : ;contact=sip:bob at 127.0.0.1:5062\;transport=udp
Remove this as well.


https://gerrit.asterisk.org/#/c/34/1/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_app/test-config.yaml
File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_app/test-config.yaml:

Line 1
Since 12 isn't receiving a whole lot of attention - and it is plausible that *something* would go wrong in attended transfers in 12.0.0 - I'd make the minversion here 13.0.0.


https://gerrit.asterisk.org/#/c/34/1/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_app/configs/ast1/pjsip.conf
File tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_app/configs/ast1/pjsip.conf:

Line 25: ; TODO remove
       : ;contact=sip:alice at 127.0.0.1:5061\;transport=udp
Remove


Line 40: ; TODO remove
       : ;contact=sip:bob at 127.0.0.1:5062\;transport=udp
Remove.


https://gerrit.asterisk.org/#/c/34/1/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_app/test-config.yaml
File tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_app/test-config.yaml:

Line 174:     minversion: '12.0.0'
minversion of 13.0.0


-- 
To view, visit https://gerrit.asterisk.org/34
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61b70f83013b8d37de3fe1eea53c8dd2d026d2e0
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes