[asterisk-dev] [Code Review] 4604: loader/main: Don't set ast_fully_booted until deferred reloads are processed

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4604/#review15138
-----------------------------------------------------------



branches/13/main/loader.c
<https://reviewboard.asterisk.org/r/4604/#comment25799>

    Please just remove this check.  This function is listed in _private.h, so it is intended to be used by asterisk.c in the startup process and nothing else.  It will never be called before the proper time.
    
    I think this is actually where you want to set modules_loaded = 1.



branches/13/main/loader.c
<https://reviewboard.asterisk.org/r/4604/#comment25798>

    Please remove this, it's simpler to just do it in ast_process_pending_reloads.  There are a couple initializations that happen after final modules load, I don't think we want to start allowing reloads earlier than right before setting ast_fullybooted.


- Corey Farrell


On April 8, 2015, 4:14 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4604/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Until we have a true module management facility it's sometimes necessary for one module to force a reload on another before its own load is complete.  If Asterisk isn't fully booted yet, these reloads are deferred.  The problem is that asterisk reports fully booted before processing the deferred reloads which means Asterisk really isn't quite ready when it says it is.
> 
> This patch moves the report of fully booted after the processing of the deferred reloads is complete.
> 
> 
> Diffs
> -----
> 
>   branches/13/main/loader.c 434447 
>   branches/13/main/asterisk.c 434447 
> 
> Diff: https://reviewboard.asterisk.org/r/4604/diff/
> 
> 
> Testing
> -------
> 
> Since the pjsip stack has the most number of related modules, I'm running the channels/pjsip testsuite to make sure there aren't any issues.  So far...none.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150409/360b2f4f/attachment.html>