[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

[Ashley Sanders (Code Review)]

Ashley Sanders has posted comments on this change.

Change subject: stasis: set a channel variable on websocket disconnect error
......................................................................


Patch Set 5:

(3 comments)

Found more draft comments that gerrit obscured from me earlier =)

https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/ari_client.py
File tests/rest_api/applications/stasisstatus/ari_client.py:

Line 76:             msg = '{0} '.format(self)
This variable is not being used - it should be used in the logger statements below.


https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/observable_object.py
File tests/rest_api/applications/stasisstatus/observable_object.py:

Line 50:         event                 -- The list of callbacks to invoke.
This description should read, "The name of the event being raised."


https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/test_scenario.py
File tests/rest_api/applications/stasisstatus/test_scenario.py:

Minor pet peeve: I flip-flopped between using \" and \' for string literals. I prefer consistency, so since the other files use \', update this file to use \', also.


-- 
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f7dadfd429bd30e9f07a531f47884d8c923fc13
Gerrit-PatchSet: 5
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes