[asterisk-dev] [Code Review] 4597: res_pjsip: add CLI command to show global and system configuration

Joshua Colp reviewboard at asterisk.org
Wed Apr 8 12:54:27 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15133
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On April 8, 2015, 5:52 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 5:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
>     https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a new CLI command for res_pjsip that shows both global and system configuration settings:
> 
> pjsip show settings
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip/include/res_pjsip_private.h 434423 
>   branches/13/res/res_pjsip/config_system.c 434423 
>   branches/13/res/res_pjsip/config_global.c 434423 
>   branches/13/res/res_pjsip.c 434423 
>   branches/13/CHANGES 434423 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> -------
> 
> Ran the command and checked output. Changed some options and reloaded and made sure global settings changed, but system ones did not. Changed some settings again and restarted and made sure both global and system changes took effect. Also removed the sections completely from the pjsip.conf file and made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150408/0f231714/attachment.html>


More information about the asterisk-dev mailing list