[asterisk-dev] [Code Review] 4592: chan_pjsip: 183 sent when inband_progress=no

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4592/
-----------------------------------------------------------

(Updated April 8, 2015, 12:07 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Bugs: ASTERISK-24835
    https://issues.asterisk.org/jira/browse/ASTERISK-24835


Repository: Asterisk


Description
-------

The issue started out as early media not playing in chan_sip. However, it was then reported that once the 'progressinband' option was set to 'yes' it would work, but that the default behavior was different than that of chan_pjsip. chan_pjsip's 'inband_progress' option defaults to 'no' as well, but it still sends a 183. It turns out chan_pjsip was always sending a 183 despite whatever the 'inband_progress' option was set to. Fixed it so chan_pjsip only sends a 183 if 'inband_progress' is set to 'yes'.


Diffs
-----

  branches/13/channels/chan_pjsip.c 434021 

Diff: https://reviewboard.asterisk.org/r/4592/diff/


Testing
-------

Duplicated the issue with chan_pjsip always sending the 183. After the patch it will only send it when 'inband_progress' is set to 'yes'


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150408/29901f88/attachment.html>