[asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

[Juergen Spies]

> On April 7, 2015, 7:06 p.m., Mark Michelson wrote:
> > I want to give this a "Ship It!" but the "Testing Done" section is not filled in at all. What has been done to test this change?

I did test the 1st version of the patch even if I somehow missed that I should document it in the "Testing Done" field.
The 2nd version of the patch I will test on Friday. I will document the results then.


- Juergen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/#review15103
-----------------------------------------------------------


On April 6, 2015, 3:53 p.m., Juergen Spies wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4589/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 3:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24928
>     https://issues.asterisk.org/jira/browse/ASTERISK-24928
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default value or a value provided
> in pjsip.conf (t38_udptl_maxdatagram).
> Without this far_max_datagram remains -1 if the remote endpoint does not provide the MediaAttribute T38FaxMaxDatagram
> in it's SIP INVITE SDP. This will result in the INVITE being rejected.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_t38.c 433967 
> 
> Diff: https://reviewboard.asterisk.org/r/4589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Juergen Spies
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/85427483/attachment.html>