[asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
-----------------------------------------------------------

(Updated April 7, 2015, 5:35 p.m.)


Review request for Asterisk Developers.


Changes
-------

Combined the two commands into a single one: 'pjsip show settings'


Bugs: ASTERISK-24918
    https://issues.asterisk.org/jira/browse/ASTERISK-24918


Repository: Asterisk


Description
-------

Added two new CLI commands for res_pjsip global and system configuration settings:

pjsip show global
pjsip show system


Diffs (updated)
-----

  branches/13/res/res_pjsip/include/res_pjsip_private.h 434150 
  branches/13/res/res_pjsip/config_system.c 434150 
  branches/13/res/res_pjsip/config_global.c 434150 
  branches/13/res/res_pjsip.c 434150 
  branches/13/CHANGES 434150 

Diff: https://reviewboard.asterisk.org/r/4597/diff/


Testing
-------

Ran the commands and checked output. Changed some options and reloaded and made sure global settings changed, but system ones did not. Changed some settings again and restarted and made sure both global and system changes too effect. Also removed the sections completely from the pjsip.conf file and made sure the defaults were shown.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/9cef7758/attachment.html>