[asterisk-dev] [Code Review] 4595: Voicemail API: fix handling of mailbox full condition

Mark Michelson reviewboard at asterisk.org
Tue Apr 7 14:02:34 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4595/#review15101
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On April 6, 2015, 8:20 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4595/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 8:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24942
>     https://issues.asterisk.org/jira/browse/ASTERISK-24942
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In r115582 (2008), the ERROR_MAILBOX_FULL flag was removed, and a check of the save_to_folder result no longer handled the mailbox full condition.  This lead to the deletion of a new Inbox message, once played, that could not be relocated to the Old mailbox because of the maxmsg limit.  This patch restores the original functionality lost, which is to leave the message in the Inbox without deleting it.
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/app_voicemail.c 434135 
> 
> Diff: https://reviewboard.asterisk.org/r/4595/diff/
> 
> 
> Testing
> -------
> 
> Tested manually on my system under Asterisk 13.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/3424263d/attachment.html>


More information about the asterisk-dev mailing list