[asterisk-dev] [Code Review] 4536: iax2_poke_noanswer expiration timer too short

[Y Ateya]

> On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
> >
> 
> Matt Jordan wrote:
>     Also, please remember to close findings that you feel have been resolved. Otherwise, it is difficult to know what all has been addressed between reviews.

ok.


> On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
> > trunk/channels/chan_iax2.c, lines 12365-12375
> > <https://reviewboard.asterisk.org/r/4536/diff/2/?file=73573#file73573line12365>
> >
> >     I would put a comment in here explaining why the schedule times are chosen as they are. 5/6 feels arbitrary without some explanation.

Using *5/6 is **really** arbitrary; I just want number less than maximum value. This is used because POKE next cycle will be after {{pokefreqnotok}}, so I want current poke to expire before the next new poke is sent.

So which multiplier to use, 5/6, 9/10, 99/100, 9999/10000, ... etc. It needs to be something less than 1.

I chose 5/6 because it is used in registration renewals {{(5 * reg->refresh / 6)}}

What do you recommend to document this multiplier?


> On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
> > trunk/channels/chan_iax2.c, lines 12367-12372
> > <https://reviewboard.asterisk.org/r/4536/diff/2/?file=73573#file73573line12367>
> >
> >     While I know you didn't introduce this, the coding guidelines stipulate that you should use braces even over single line statements. Macros have caused us extreme pain in the past.
> >     
> >     if (peer->lastms < 0) {
> >        ...
> >     } else {
> >        ...
> >     }
> >

Sure.


- Y


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15090
-----------------------------------------------------------


On April 3, 2015, 7:58 p.m., Y Ateya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4536/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 7:58 p.m.)
> 
> 
> Review request for Asterisk Developers and rnewton.
> 
> 
> Bugs: ASTERISK-24894
>     https://issues.asterisk.org/jira/browse/ASTERISK-24894
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Increase POKE retry window from DEFAULT_MAXMS * 2 (4 seconds) to bigger number (derived from qualify time; which control POKE retry time).
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_iax2.c 432806 
> 
> Diff: https://reviewboard.asterisk.org/r/4536/diff/
> 
> 
> Testing
> -------
> 
> - Tried test with multiple qualify values (2 and 10 seconds).
> - Tried test with 100% packets loss to ensure that when a POKE packet is dropped it will be retried couple of time before declaring client disconnected.
> 
> 
> Thanks,
> 
> Y Ateya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/328dd198/attachment-0001.html>