[asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4598/#review15092
-----------------------------------------------------------



/team/group/dns/main/dns_test.c
<https://reviewboard.asterisk.org/r/4598/#comment25772>

    Consider saving the string length to a variable so you won't have to calculate it several times.



/trunk/main/dns_core.c
<https://reviewboard.asterisk.org/r/4598/#comment25769>

    No value is set on true.



/trunk/main/dns_naptr.c
<https://reviewboard.asterisk.org/r/4598/#comment25770>

    Extraneous merge nomenclature.


- Kevin Harwell


On April 6, 2015, 5:46 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4598/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 5:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Josh worked on SRV in one branch, and I worked on NAPTR in a separate branch. Independently we kept coming to realizations that something that one of us had developed independently would be needed by the other person. We decided to simply have copies of common functionality in our branches. After merging, we would perform a refactor to remove duplication.
> 
> This changeset introduces no new DNS functionality. Instead, it takes some duplicated code and places them into common areas of the DNS core.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_dns_srv.c 434186 
>   /trunk/tests/test_dns_naptr.c 434186 
>   /trunk/main/dns_srv.c 434186 
>   /trunk/main/dns_naptr.c 434186 
>   /trunk/main/dns_core.c 434186 
>   /trunk/include/asterisk/dns_internal.h 434186 
>   /team/group/dns/main/dns_test.c PRE-CREATION 
>   /team/group/dns/include/asterisk/dns_test.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4598/diff/
> 
> 
> Testing
> -------
> 
> All DNS unit tests continue to pass.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/413bba82/attachment.html>