[asterisk-dev] [Code Review] 4575: bridge.c: Hangup attended transfer target after it has been swapped out

Kevin Harwell reviewboard at asterisk.org
Tue Apr 7 11:41:06 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4575/
-----------------------------------------------------------

(Updated April 7, 2015, 11:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 434240


Bugs: ASTERISK-24782
    https://issues.asterisk.org/jira/browse/ASTERISK-24782


Repository: Asterisk


Description
-------

After completing an attended transfer the transfer target channel (the one that gets swapped out) was not being hung up after leaving the bridge. This resulted in a channel possibly being left around. Added an explicit softhangup for the channel in question after the transfer is successfully completed in order to make sure the channel is hung up.


Diffs
-----

  branches/13/main/bridge.c 433917 

Diff: https://reviewboard.asterisk.org/r/4575/diff/


Testing
-------

There was a testsuite test that initially caught the problem. Ran the modified test (had been set to always pass) after applying the patch and it worked as expected. Also did some manual testing with different attended transfer scenarios.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/07b600f0/attachment.html>


More information about the asterisk-dev mailing list