[asterisk-dev] [Code Review] 4536: iax2_poke_noanswer expiration timer too short

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15090
-----------------------------------------------------------



trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/4536/#comment25768>

    I would put a comment in here explaining why the schedule times are chosen as they are. 5/6 feels arbitrary without some explanation.



trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/4536/#comment25767>

    While I know you didn't introduce this, the coding guidelines stipulate that you should use braces even over single line statements. Macros have caused us extreme pain in the past.
    
    if (peer->lastms < 0) {
       ...
    } else {
       ...
    }
    


- Matt Jordan


On April 3, 2015, 2:58 p.m., Y Ateya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4536/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 2:58 p.m.)
> 
> 
> Review request for Asterisk Developers and rnewton.
> 
> 
> Bugs: ASTERISK-24894
>     https://issues.asterisk.org/jira/browse/ASTERISK-24894
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Increase POKE retry window from DEFAULT_MAXMS * 2 (4 seconds) to bigger number (derived from qualify time; which control POKE retry time).
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_iax2.c 432806 
> 
> Diff: https://reviewboard.asterisk.org/r/4536/diff/
> 
> 
> Testing
> -------
> 
> - Tried test with multiple qualify values (2 and 10 seconds).
> - Tried test with 100% packets loss to ensure that when a POKE packet is dropped it will be retried couple of time before declaring client disconnected.
> 
> 
> Thanks,
> 
> Y Ateya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150407/2c154e6c/attachment-0001.html>