[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Matt Jordan (Code Review) asteriskteam at digium.com
Tue Apr 7 08:48:08 CDT 2015


Matt Jordan has submitted this change and it was merged.

Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
......................................................................


non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Due to a bug in Asterisk, in some cases, the channel would not be hung up after
leaving the bridge upon completing an attended transfer. With that fixed this
test can now be expected to pass, so the 'expected-result: False' has been
removed. Also a couple of events attempted to match against the wrong regex,
so those were modified accordingly.

Change-Id: I0a3bcb1a0df7e7bdca02be827288f5f08b5140ce
---
M tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  John Bigelow: Looks good to me, but someone else must approve
  Matt Jordan: Looks good to me, approved; Verified
  Ashley Sanders: Looks good to me, but someone else must approve
  Corey Farrell: Looks good to me, but someone else must approve



diff --git a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
index 97009bb..2ec68b6 100644
--- a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
+++ b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
@@ -311,7 +311,7 @@
             conditions:
                 match:
                     Event: 'BridgeLeave'
-                    Channel: 'Local/_attended-.*;1'
+                    Channel: 'Local/_attended at transfer-.*;1'
                 nomatch:
                     BridgeUniqueid: 'test_bridge'
             count: 1
@@ -320,7 +320,7 @@
             conditions:
                 match:
                     Event: 'Hangup'
-                    Channel: 'Local/_attended-.*;1'
+                    Channel: 'Local/_attended at transfer-.*;1'
             count: 1
     # Ensure the local channel half in Stasis bridge with carol leaves the
     # bridge.
@@ -332,7 +332,7 @@
                 bridge:
                     id: 'test_bridge'
                 channel:
-                    name: 'Local/_attended-.*;2'
+                    name: 'Local/_attended at transfer-.*;2'
             count: 1
     # Ensure the local channel half in Stasis bridge with carol exits the
     # Stasis app. Then hang up carol.
@@ -342,7 +342,7 @@
                 type: StasisEnd
                 application: 'testsuite'
                 channel:
-                    name: 'Local/_attended-.*;2'
+                    name: 'Local/_attended at transfer-.*;2'
             count: 1
         ari-requests:
             method: 'delete'
@@ -393,6 +393,3 @@
     tags:
         - ARI
         - pjsip
-    # Expect test to fail until ASTERISK-24782 is resolved.
-    expected-result: False
-

-- 
To view, visit https://gerrit.asterisk.org/25
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a3bcb1a0df7e7bdca02be827288f5f08b5140ce
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-dev mailing list