[asterisk-dev] [Code Review] 4581: build: Fixes for gcc 5 compilation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4581/#review15079
-----------------------------------------------------------

Ship it!


The issue below is minor and can be tweaked on commit.


branches/11/main/ccss.c
<https://reviewboard.asterisk.org/r/4581/#comment25758>

    Shouldn't this be:
    
    if (sscanf(value, "%30u", &value_ast_uint) != 1) {
       ...
    }


- Matt Jordan


On April 3, 2015, 1:44 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4581/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 1:44 p.m.)
> 
> 
> Review request for Asterisk Developers and Scott Griepentrog.
> 
> 
> Bugs: ASTERISK-24932
>     https://issues.asterisk.org/jira/browse/ASTERISK-24932
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> These are fixes for compilation under gcc 5.0...
> 
> chan_sip.c:    In parse_request needed to make 'lim' unsigned.
> inline_api.h:  Needed to add a check for '__GNUC_STDC_INLINE__' to detect C99 inline semantics (same as clang).
> ccss.c:        In ast_cc_set_parm, needed to fix weird comparison.
> dsp.c:         Needed to work around a possible compiler bug.  It was throwing an array-bounds error but neither
>                sgriepentrog, rmudgett nor I could figure out why.
> manager.c:     In action_atxfer, needed to correct an array allocation.
> 
> If I can reproduce the possible gcc bug in a short test case, I'll submit it upstream.
> 
> This patch will go to 11, 13, trunk.
> 
> Reported-by: Jeffrey Ollie
> 
> 
> Diffs
> -----
> 
>   branches/11/main/manager.c 433966 
>   branches/11/main/dsp.c 433966 
>   branches/11/main/ccss.c 433966 
>   branches/11/include/asterisk/inline_api.h 433966 
>   branches/11/channels/chan_sip.c 433966 
> 
> Diff: https://reviewboard.asterisk.org/r/4581/diff/
> 
> 
> Testing
> -------
> 
> Ran unit and testsuite tests.  No differences detected.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150406/36635bc1/attachment.html>