[asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4576/#review15078
-----------------------------------------------------------


Nice job on the test! Just a few minor documentation findings.

For future reference, the Asterisk Test Suite has been migrated over to Git. You can get the latest and greatest from gerrit.asterisk.org - and also post any new patches there as well. Instructions on using Gerrit are up on the Asterisk wiki:

https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

I'll be happy to move the patch over for you if you don't want to go through the hassle.




/asterisk/trunk/tests/channels/pjsip/auto_dtmf/test-config.yaml
<https://reviewboard.asterisk.org/r/4576/#comment25755>

    I think you might have a copy/paste issue here on the summary and description :-)
    
    



/asterisk/trunk/tests/channels/pjsip/auto_dtmf/test-config.yaml
<https://reviewboard.asterisk.org/r/4576/#comment25756>

    The minversion should be 13.4.0, as that is when the 'auto' support mode will be added.



/asterisk/trunk/tests/channels/pjsip/auto_dtmf/test-config.yaml
<https://reviewboard.asterisk.org/r/4576/#comment25757>

    You don't need to specify that the test depends on those modules.


- Matt Jordan


On April 2, 2015, 9:04 a.m., yaron nahum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4576/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 9:04 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24706
>     https://issues.asterisk.org/jira/browse/ASTERISK-24706
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is the testsuite test to test the auto_dtmf option added by review:
> https://reviewboard.asterisk.org/r/4438/
> 
> The test passes.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 6564 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/sipp/dtmf_rfc2833.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/sipp/dtmf_inband.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/auto_dtmf/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> yaron nahum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150406/cb7aa905/attachment-0001.html>