[asterisk-dev] [Code Review] 4582: res_pjsip: config option 'timers' can't be set to 'no'

[Kevin Harwell]

> On April 3, 2015, 4:28 p.m., rmudgett wrote:
> > branches/13/res/res_pjsip/pjsip_configuration.c, lines 152-153
> > <https://reviewboard.asterisk.org/r/4582/diff/1/?file=73574#file73574line152>
> >
> >     Are the flags exclusive to each other?
> >     Maybe SUPPORT is needed to enable the functionality and REQUIRE to make it mandatory.

I looked at the pjsip code and they seem to take care of adding the other flags if needed, so I figured to just let them handle it.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/#review15048
-----------------------------------------------------------


On April 3, 2015, 2:58 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4582/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 2:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24910
>     https://issues.asterisk.org/jira/browse/ASTERISK-24910
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When setting the configuration option 'timers' equal to 'no' the bit flag was not properly negated. This patch clears all associated flags and only sets the specified one. pjsip will handle any necessary flag combinations. Also went ahead and did similar for the '100rel' option.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip/pjsip_configuration.c 433966 
> 
> Diff: https://reviewboard.asterisk.org/r/4582/diff/
> 
> 
> Testing
> -------
> 
> Made sure the option can now be set to 'no' and that it clears the bit. Also set it to the other values and reloaded to make sure the field was updated correctly.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150403/81b314ee/attachment.html>