[asterisk-dev] [Code Review] 4588: IAX make calltoken expiration time configurable

[Y Ateya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/
-----------------------------------------------------------

(Updated April 3, 2015, 10:06 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added configuration variable to iax.sample.conf 


Bugs: ASTERISK-24939
    https://issues.asterisk.org/jira/browse/ASTERISK-24939


Repository: Asterisk


Description
-------

The section 4.1 in call token changes to IAX protocol (http://downloads.asterisk.org/pub/security/IAX2-security.html):

 "The token timeout will be hard coded at 10 seconds for now. However, it may be made configurable at some point if it seems to be a useful addition"

In case of lagged network cases (or bad network which required multiple retries) 10 seconds is not enough.

Changes:
 - Change name of MAX_CALLTOKEN_DELAY to lower case and remove const.
 - Add general configuration variable `calltokenexpiration`


Diffs (updated)
-----

  trunk/configs/samples/iax.conf.sample 432806 
  trunk/channels/chan_iax2.c 432806 

Diff: https://reviewboard.asterisk.org/r/4588/diff/


Testing
-------


Thanks,

Y Ateya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150403/237a59e4/attachment.html>