[asterisk-dev] [Code Review] 4586: AMI: Fix improper handling of lines that are exactly 1025 bytes long.

Corey Farrell reviewboard at asterisk.org
Fri Apr 3 15:57:55 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4586/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-20524
    https://issues.asterisk.org/jira/browse/ASTERISK-20524


Repository: Asterisk


Description
-------

When AMI receives a line that is 1025 bytes long, it sends two error messages.  Copy the last byte in the buffer to the first postiion, set the length to 1.


Diffs
-----

  /branches/11/main/manager.c 433967 

Diff: https://reviewboard.asterisk.org/r/4586/diff/


Testing
-------

Testsuite - tests/manager against Asterisk 13.  All passed.
Manually tested against 11 using David's script posted to JIRA.  Verified a single error is received for lines 1025 or more, lines 1024 or less succeed.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150403/3cd3995f/attachment.html>


More information about the asterisk-dev mailing list