[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

[Kevin Harwell (Code Review)]

Kevin Harwell has posted comments on this change.

Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
......................................................................


Patch Set 3:

Updated the per review based on feedback and other findings.

A couple of things:
1. I am an idiot and my eyes were playing tricks on me, but there is actually nothing wrong with the regex parsing of '-'. The regex on those particular events were missing some text.

2. To answer John and Corey's question about why that particular event action was moved: There original reason was after applying the Asterisk fix the test was still failing due to what seemed like bob being hung up too early. I moved it thinking there might have been bit of a race between events, but it turned out the problem was due to the regex being wrong on some events. Then I forgot to move it back. I've now moved it back and will leave the comment there since it applies again.

-- 
To view, visit https://gerrit.asterisk.org/25
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3bcb1a0df7e7bdca02be827288f5f08b5140ce
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No