[asterisk-dev] [Code Review] 4108: Weak Proxy Objects

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
-----------------------------------------------------------

(Updated April 3, 2015, 12:58 p.m.)


Review request for Asterisk Developers, George Joseph and rmudgett.


Changes
-------

* Address Richards findings.
* Enable REF_DEBUG.
* Rename some variables in the test to make it easier to trace, added ao2 REF_DEBUG tag's.
* Add JIRA ticket.


Bugs: ASTERISK-24936
    https://issues.asterisk.org/jira/browse/ASTERISK-24936


Repository: Asterisk


Description (updated)
-------

This implements "weak" references.  The weakproxy object is a real ao2 with normal reference counting of its own.  When a weakproxy is pointed to a normal object they hold references to each other.  The normal object is automatically freed when a single reference remains (the weakproxy).  The weakproxy also supports subscriptions that will notify callbacks when it does not point to any real object.


Diffs (updated)
-----

  /trunk/tests/test_astobj2_weaken.c PRE-CREATION 
  /trunk/main/astobj2.c 433964 
  /trunk/include/asterisk/astobj2.h 433964 

Diff: https://reviewboard.asterisk.org/r/4108/diff/


Testing
-------

Ran the included test with REF_DEBUG enabled under valgrind.  No reference leaks or improper memory access.  Though this does not test for races, I don't know of an automated way to do that.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150403/293eef10/attachment.html>