[asterisk-dev] [Code Review] 4578: res_pjsip_phoneprov_provider: Fix leaked OBJ_MULTIPLE iterator.

George Joseph reviewboard at asterisk.org
Fri Apr 3 10:02:15 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4578/#review15041
-----------------------------------------------------------

Ship it!


Ship It!

- George Joseph


On April 3, 2015, 7:31 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4578/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 7:31 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24935
>     https://issues.asterisk.org/jira/browse/ASTERISK-24935
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> res_pjsip_phoneprov_provider was using ao2_callback with OBJ_MULTIPLE, then ignoring the return.  This resulted in a reference leak.  Added OBJ_NODATA flag.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_phoneprov_provider.c 433966 
> 
> Diff: https://reviewboard.asterisk.org/r/4578/diff/
> 
> 
> Testing
> -------
> 
> Started and stopped Asterisk, REF_DEBUG now showing no leaks.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150403/32ed9a80/attachment.html>


More information about the asterisk-dev mailing list