[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Couple nit-picks about a comment / commit message.  Once the review is updated I will +1.

https://gerrit.asterisk.org/#/c/25/2/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
File tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml:

Line 276:         ami-actions:
        :             action:
        :                action: 'Hangup'
        :                channel: '/^PJSIP/bob-.*$/'
> I'm curious as to why this was moved.
I'm also curious, this change should probably be mentioned in the commit message.


Line 281:     # Ensure alice's second channel exits the Stasis app. Then hang up bob.
Please update this comment.


-- 
To view, visit https://gerrit.asterisk.org/25
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3bcb1a0df7e7bdca02be827288f5f08b5140ce
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: John Bigelow <jbigelow at digium.com>
Gerrit-HasComments: Yes