[asterisk-dev] [Code Review] 4571: Add usegmtime option to cel_pgsql

Mark Michelson reviewboard at asterisk.org
Wed Apr 1 17:54:58 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/#review15023
-----------------------------------------------------------


Just commenting to say that aside from what Matt has already pointed out, I did not see anything else wrong with the change. So if you get his findings cleared up, this will get a "Ship it!" from me.

- Mark Michelson


On March 31, 2015, 1:19 a.m., Rodrigo Ramirez Norambuena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4571/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 1:19 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-23186
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-23186
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Feature for added an option that lets you specify that the timestamps going into PostgreSQL from CEL log should be in GMT instead of local time.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/cel_pgsql.conf.sample 406488 
>   /trunk/cel/cel_pgsql.c 406488 
>   /trunk/CHANGES 406488 
> 
> Diff: https://reviewboard.asterisk.org/r/4571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rodrigo Ramirez Norambuena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150401/63b4b6a9/attachment-0001.html>


More information about the asterisk-dev mailing list