[asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

Mark Michelson reviewboard at asterisk.org
Wed Apr 1 17:43:48 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4574/#review15021
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On April 1, 2015, 9:20 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4574/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 9:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A compatibility problem was introduced in r430179 (https://reviewboard.asterisk.org/r/4308) when a new variable was inserted into the struct ast_sip_session.  This change puts that new variable at the end of the structure to avoid misalignment of the values.
> 
> This also affects releases 13.2 and 13.3.
> 
> 
> Diffs
> -----
> 
>   /branches/13/include/asterisk/res_pjsip_session.h 433918 
> 
> Diff: https://reviewboard.asterisk.org/r/4574/diff/
> 
> 
> Testing
> -------
> 
> With this change, a DPMA crash has been eliminated when transmitting messages via PJSIP.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150401/6c2ae758/attachment.html>


More information about the asterisk-dev mailing list