[asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
-----------------------------------------------------------

(Updated April 1, 2015, 2:51 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review feedback from Matt and Kevin.

* Added Doxygen comments for NAPTR data and DNS record data_ptr
* Added safety checks to return NULL if NAPTR record not found in DNS result.
* Macrotized the check if we are past the end of the NAPTR record when parsing.
* Short-circuit the sort operation if fewer than two NAPTR records are returned
* Removed "ast_" prefix from internal DNS routines.
* Error messages for nominal tests are more descriptive


Repository: Asterisk


Description
-------

This adds NAPTR support for DNS in Asterisk.

The main parts of this are the functions for allocating a DNS NAPTR record when a resolver wishes to add a NAPTR record, the sorting algorithm for sorting DNS NAPTR records, and the tests that use a mock DNS resolver.

NOTE: There is likely to be some overlap here in this review and Josh's SRV review (/r/4528). Our stance on this is that we will factor out the duplicated code once both SRV and NAPTR have been merged into the main DNS branch. The factoring out of common functions will be placed in its own review.


Diffs (updated)
-----

  /team/group/dns/tests/test_dns_naptr.c PRE-CREATION 
  /team/group/dns/res/res_resolver_unbound.c 433885 
  /team/group/dns/main/dns_naptr.c 433885 
  /team/group/dns/main/dns_core.c 433885 
  /team/group/dns/include/asterisk/dns_internal.h 433885 

Diff: https://reviewboard.asterisk.org/r/4542/diff/


Testing
-------

All previous DNS tests continue to pass, and all new tests added in this review pass as well.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150401/140756a8/attachment.html>